Adding date filter to GetNodesCounts API #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lance Finfrock <[email protected]>
Signed-off-by: Lance Finfrock <[email protected]>
lancewf
force-pushed
the
lancewf/getnodescount_date_filters
branch
from
1cf00d2 to
1f808d9
Compare
added 3 commits
May 5, 2020 11:52
Signed-off-by: Lance Finfrock <[email protected]>
…escount_date_filters
Signed-off-by: Lance Finfrock <[email protected]>
lancewf
commented
May 5, 2020
| var ns = *new(backend.NodesCounts) | ||
|
|
||
| // Adding the exists = true filter to the list of filters, because nodes | ||
| // have documents that persist in elasticsearch to hold historical data | ||
| // even after the node no longer exists | ||
| filters["exists"] = []string{"true"} | ||
|
|
||
| boolQuery := newBoolQueryFromFilters(filters) | ||
| mainQuery := newBoolQueryFromFilters(filters) |
There was a problem hiding this comment.
This is the main change with this PR. The rest is passing the start and end date to this function.
lancewf
commented
May 5, 2020
| @@ -461,13 +461,43 @@ func TestStatsNodesCountsWhen20Nodes(t *testing.T) { | |||
| func TestStatsNodesCountsFilteringWithTableDriven(t *testing.T) { | |||
| dataNodes := []struct { | |||
| number int | |||
| node iBackend.NodeInfo | |||
| node iBackend.Node | |||
There was a problem hiding this comment.
Updated this to be a node to allow for Checkin datetime variation.
vjeffrey
approved these changes
May 6, 2020
This was referenced Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Adding date filters to the GetNodesCounts allows a user to filter on nodes that have check-in between a specific period. This was added for the insight UI control for the Desktop view.
⛓️ Related Resources
#3372
👟 How to Build and Test the Change
build components/config-mgmt-service && build components/automate-gateway && start_all_servicesfor i in {1..5}; do generate_chef_run_example | jq --arg d $(date +%FT%TZ -d "$i day ago") '.end_time=$d' | send_chef_data_raw; donecurl -f --insecure -H "api-token: $(get_api_token)" --data-urlencode "start=$(date +%FT%TZ -d '3 day ago')" --data-urlencode "end=$(date +%FT%TZ -d '1 day ago')" https://localhost/api/v0/cfgmgmt/stats/node_counts | jq✅ Checklist